keith-turner commented on code in PR #4311:
URL: https://github.com/apache/accumulo/pull/4311#discussion_r1505160846
##########
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java:
##########
@@ -51,7 +53,8 @@ class InitialConfiguration {
this.siteConf = siteConf;
initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER.getKey(),
SimpleCompactionDispatcher.class.getName());
- initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() +
"service", "root");
+ initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() +
"service",
Review Comment:
> but I'm not sure how the compaction properties will be handled.
The prop settings in the metadata table may be syntactically correct and
semantically incorrect. Not sure the upgrade will catch that, depends on how
deep the validation goes.
> I'm fine with removing these entirely.
Thinking we should remove them if what they are set to is equivalent to the
defaults. Seems less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
