keith-turner commented on code in PR #4311:
URL: https://github.com/apache/accumulo/pull/4311#discussion_r1505033454
##########
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java:
##########
@@ -51,7 +53,8 @@ class InitialConfiguration {
this.siteConf = siteConf;
initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER.getKey(),
SimpleCompactionDispatcher.class.getName());
- initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() +
"service", "root");
+ initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() +
"service",
Review Comment:
We may be able to set no compaction dispatcher properties here. If we set
nothing then it would fall back to the default config for all tables which
should dispatch to the default service. So maybe we can remove the puts for
all compaction dispatcher props for all tables in this class.
We should open a follow on issue to address the props during upgrade if
there is not something that covers that. May be better as part of a larger
issue w/ a checklist of stuff related to compaction upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
