keith-turner commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1612414536
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -495,8 +496,8 @@ public void addSplits(String tableName, SortedSet<Text>
partitionKeys)
CountDownLatch latch = new CountDownLatch(splits.size());
AtomicReference<Exception> exception = new AtomicReference<>(null);
- ExecutorService executor =
-
context.threadPools().getPoolBuilder("addSplits").numCoreThreads(16).build();
+ ExecutorService executor = context.threadPools()
+ .getPoolBuilder(METRICS_POOL_PREFIX +
"table.ops.add.splits").numCoreThreads(16).build();
Review Comment:
I don't think this thread pool will emit metrics because metrics are not
being turned on in the builder. So this change will just impact the name of
the thread as seen in jstack, was that the intention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
