EdColeman commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1617617859


##########
server/base/src/main/java/org/apache/accumulo/server/client/BulkImporter.java:
##########
@@ -362,8 +364,8 @@ private Map<Path,List<AssignmentInfo>> estimateSizes(final 
VolumeManager vm,
 
     final Map<Path,List<AssignmentInfo>> ais = Collections.synchronizedMap(new 
TreeMap<>());
 
-    ExecutorService threadPool = 
ThreadPools.getServerThreadPools().getPoolBuilder("estimateSizes")
-        .numCoreThreads(numThreads).build();
+    ExecutorService threadPool = ThreadPools.getServerThreadPools()
+        
.getPoolBuilder("bulk.import.estimate.sizes.pool").numCoreThreads(numThreads).build();

Review Comment:
   Fixed in 21aa29c435



##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropCacheCaffeineImpl.java:
##########
@@ -45,8 +46,8 @@ public class PropCacheCaffeineImpl implements PropCache {
   public static final int EXPIRE_MIN = 60;
   private static final Logger log = 
LoggerFactory.getLogger(PropCacheCaffeineImpl.class);
   private static final Executor executor =
-      
ThreadPools.getServerThreadPools().getPoolBuilder("caffeine-tasks").numCoreThreads(1)
-          .numMaxThreads(20).withTimeOut(60L, SECONDS).build();
+      ThreadPools.getServerThreadPools().getPoolBuilder(METRICS_POOL_PREFIX + 
"caffeine.task")

Review Comment:
   Fixed in 21aa29c435



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to