EdColeman commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1612422155
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -495,8 +496,8 @@ public void addSplits(String tableName, SortedSet<Text>
partitionKeys)
CountDownLatch latch = new CountDownLatch(splits.size());
AtomicReference<Exception> exception = new AtomicReference<>(null);
- ExecutorService executor =
-
context.threadPools().getPoolBuilder("addSplits").numCoreThreads(16).build();
+ ExecutorService executor = context.threadPools()
+ .getPoolBuilder(METRICS_POOL_PREFIX +
"table.ops.add.splits").numCoreThreads(16).build();
Review Comment:
The goal was to try to be consistent across all names. It would make is
easier to recognize that it was a pool It seemed adopting a convention would
help anywhere the name could show up, logs, jstacks,...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
