EdColeman commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1617618231
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java:
##########
@@ -306,25 +311,25 @@ public TabletServerResourceManager(ServerContext context,
TabletHostingServer ts
Property.TSERV_MINC_MAXCONCURRENT, true);
modifyThreadPoolSizesAtRuntime(
() ->
context.getConfiguration().getCount(Property.TSERV_MINC_MAXCONCURRENT),
- "minor compactor", minorCompactionThreadPool);
+ METRICS_TSERVER_MINOR_COMPACTOR_POOL, minorCompactionThreadPool);
- splitThreadPool =
ThreadPools.getServerThreadPools().getPoolBuilder("splitter")
- .numCoreThreads(0).numMaxThreads(1).withTimeOut(1, SECONDS)
- .enableThreadPoolMetrics(enableMetrics).build();
+ splitThreadPool = ThreadPools.getServerThreadPools()
+ .getPoolBuilder(METRICS_POOL_PREFIX +
"tserver.minor.compactor").numCoreThreads(0)
Review Comment:
Fixed in 21aa29c435
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java:
##########
@@ -335,31 +340,31 @@ public TabletServerResourceManager(ServerContext context,
TabletHostingServer ts
Property.TSERV_ASSIGNMENT_MAXCONCURRENT, enableMetrics);
modifyThreadPoolSizesAtRuntime(
() ->
context.getConfiguration().getCount(Property.TSERV_ASSIGNMENT_MAXCONCURRENT),
- "tablet assignment", assignmentPool);
+ "tserver.tablet.assignment.pool", assignmentPool);
Review Comment:
Fixed in 21aa29c435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
