dlmarion commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1619307708
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java:
##########
@@ -672,11 +673,12 @@ private class MutationWriter {
public MutationWriter(int numSendThreads) {
serversMutations = new HashMap<>();
queued = new HashSet<>();
- sendThreadPool =
context.threadPools().getPoolBuilder(this.getClass().getName())
+ sendThreadPool =
context.threadPools().getPoolBuilder("tserver.batch.writer.send.pool")
Review Comment:
Is there a reason this pool name doesn't use `METRICS_POOL_PREFIX`?
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -495,8 +496,8 @@ public void addSplits(String tableName, SortedSet<Text>
partitionKeys)
CountDownLatch latch = new CountDownLatch(splits.size());
AtomicReference<Exception> exception = new AtomicReference<>(null);
- ExecutorService executor =
-
context.threadPools().getPoolBuilder("addSplits").numCoreThreads(16).build();
+ ExecutorService executor = context.threadPools()
+ .getPoolBuilder(METRICS_POOL_PREFIX +
"table.ops.add.splits").numCoreThreads(16).build();
Review Comment:
Is it the case that all pool names will have `METRICS_POOL_PREFIX` in the
leading portion of the name? If that's intended, maybe we should add that to
the pool builder so it's done in one place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
