kevinrr888 commented on PR #5547: URL: https://github.com/apache/accumulo/pull/5547#issuecomment-2932374175
> Regarding all the comments suggesting to assertTrue(Files.isDirectory(dir)) or similar with a file, Files.isDirectory will throw an exception if it does not properly create a directory at the given path. So in most (if not all) cases here, we can rely on that exception to alert us about any failure and if no exception is thrown, we can safely assume that things were created properly. Same goes for the Files.createFile() Ah I see, feel free to resolve all those comments. I remember seeing places where you do include the assertion `assertTrue(Files.isDirectory(dir))` after the creation, which is why I thought we should be ensuring it actually exists. Maybe could remove those assertions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
