bzp2010 commented on code in PR #10950:
URL: https://github.com/apache/apisix/pull/10950#discussion_r1676779583
##########
apisix/discovery/nacos/init.lua:
##########
@@ -225,6 +224,12 @@ local function iter_and_add_service(services, values)
else
up = conf
end
+ local nacos_name_from_args = (up.discovery_args and
up.discovery_args.name)
+ or default_nacos_name
Review Comment:
I remember other service discovery implementations using different rules on
service name to handle multiple registries instead of using discovery_args,
please follow that similar.
https://apisix.apache.org/docs/apisix/discovery/kubernetes/#multi-cluster-mode-query-interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
