bzp2010 commented on code in PR #10950: URL: https://github.com/apache/apisix/pull/10950#discussion_r1676780140
########## conf/config-default.yaml: ########## @@ -296,20 +296,38 @@ nginx_config: # Config for render the template to generate n # connect: 2000 # Default 2000ms # send: 2000 # Default 2000ms # read: 5000 # Default 5000ms -# nacos: # Nacos -# host: # Nacos address(es) + +# nacos: +# name: "default" # Deprecated,see nacos.hosts.name +# host: # Deprecated,see nacos.hosts.host # - "http://${username}:${password}@${host1}:${port1}"; -# prefix: "/nacos/v1/" -# fetch_interval: 30 # Default 30s -# `weight` is the `default_weight` that will be attached to each discovered node that -# doesn't have a weight explicitly provided in nacos results -# weight: 100 # Default 100. -# timeout: -# connect: 2000 # Default 2000ms -# send: 2000 # Default 2000ms -# read: 5000 # Default 5000ms -# access_key: "" # Nacos AccessKey ID in Alibaba Cloud, notice that it's for Nacos instances on Microservices Engine (MSE) -# secret_key: "" # Nacos AccessKey Secret in Alibaba Cloud, notice that it's for Nacos instances on Microservices Engine (MSE) +# prefix: "/nacos/v1/" # Deprecated,see nacos.hosts.prefix. +# fetch_interval: 30 # default 30 sec.all nacos in config will use this config +# +# weight: 100 # Deprecated see nacos.hosts.weight +# timeout: # Deprecated see nacos.hosts.timeout +# connect: 2000 # Deprecated see nacos.hosts.timeout +# send: 2000 # Deprecated see nacos.hosts.timeout +# read: 5000 # Deprecated see nacos.hosts.timeout +# access_key: "" # Deprecated see nacos.hosts.access_key +# secret_key: "" # Deprecated see nacos.hosts.secret_key +# hosts: +# - name: "your_nacos_cluster_name" #your nacos cluster name Review Comment: The field used to identify the registry should be `id` not `name`. please follow the existing rules unless you are the first to do so. https://github.com/apache/apisix/blob/0cad3295d38de0270b5f8905fbee74a79fc5559c/conf/config-default.yaml#L398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
