bzp2010 commented on code in PR #10950:
URL: https://github.com/apache/apisix/pull/10950#discussion_r1676780761
##########
t/discovery/nacos.t:
##########
@@ -32,15 +32,26 @@ deployment:
config_provider: yaml
discovery:
nacos:
- host:
- - "http://127.0.0.1:8858";
- prefix: "/nacos/v1/"
- fetch_interval: 1
- weight: 1
- timeout:
- connect: 2000
- send: 2000
- read: 5000
+ host:
+ - "http://127.0.0.1:8858";
+ prefix: "/nacos/v1/"
+ fetch_interval: 1
+ weight: 1
+ timeout:
+ connect: 2000
+ send: 2000
+ read: 5000
+ hosts:
+ - name: nacos3
+ host:
+ - "http://127.0.0.1:8868";
+ prefix: "/nacos/v1/"
+ fetch_interval: 1
+ weight: 1
+ timeout:
+ connect: 2000
+ send: 2000
+ read: 5000
Review Comment:
I don't think a mixed mode of single registry and multiple registries should
exist, and the user should explicitly choose one or the other. This will also
simplify our testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
