bzp2010 commented on code in PR #10950: URL: https://github.com/apache/apisix/pull/10950#discussion_r1676779745
########## conf/config-default.yaml: ########## @@ -296,20 +296,38 @@ nginx_config: # Config for render the template to generate n # connect: 2000 # Default 2000ms # send: 2000 # Default 2000ms # read: 5000 # Default 5000ms -# nacos: # Nacos -# host: # Nacos address(es) + +# nacos: +# name: "default" # Deprecated,see nacos.hosts.name Review Comment: The single-registry mode that is now supported does not require a name, and I think your defaults in the code can handle that scenario. So this is not required and should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
