bzp2010 commented on code in PR #10950:
URL: https://github.com/apache/apisix/pull/10950#discussion_r1684439226
##########
t/discovery/nacos.t:
##########
@@ -32,15 +32,26 @@ deployment:
config_provider: yaml
discovery:
nacos:
- host:
- - "http://127.0.0.1:8858";
- prefix: "/nacos/v1/"
- fetch_interval: 1
- weight: 1
- timeout:
- connect: 2000
- send: 2000
- read: 5000
+ host:
+ - "http://127.0.0.1:8858";
+ prefix: "/nacos/v1/"
+ fetch_interval: 1
+ weight: 1
+ timeout:
+ connect: 2000
+ send: 2000
+ read: 5000
+ hosts:
+ - name: nacos3
+ host:
+ - "http://127.0.0.1:8868";
+ prefix: "/nacos/v1/"
+ fetch_interval: 1
+ weight: 1
+ timeout:
+ connect: 2000
+ send: 2000
+ read: 5000
Review Comment:
@shreemaan-abhishek I am proposing: anyOf host or hosts, and prohibits the
mixing of the two modes, so the following configuration is acceptable.
```
discovery:
nacos:
host: xxx
prefix: xxx
```
Or,
```
discovery:
nacos:
- id: default
host: xxx
prefix: xxx
- id: backup
host: xxx
prefix: xxx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
