>From Ali Alsuliman <[email protected]>: Attention is currently required from: Peeyush Gupta, Till Westmann. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 )
Change subject: [ASTERIXDB-3166][FUN] Error with get_object_fields with open list type ...................................................................... Patch Set 1: (7 comments) File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/get-object-fields/open-list-type/open-list-type.2.update.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/3207f863_3af30fc8 PS1, Line 22: INSERT INTO ds1([{"id": "xyz", "some_list":["a","b"]}]); we should also add some more fields: "some_record": {"x1": 9, "nested_list": ["y1", "y2"], "nested_rec": {"f1": 7}}, "some_list2": [[1,2],[3,4]], "some_list3": [{"a": 5}, {"b": 6}] File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordFieldsUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/790b1a03_aa757ccf PS1, Line 98: null we should change this to use the "open" type. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/a398788f_9e6eefad PS1, Line 162: addNestedField we should probably rename this to "addRecordField" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/cad5df4f_43acdfb8 PS1, Line 245: fieldType == null can we safely remove this after we make sure we always pass a field type (closed or open)? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/d84fa063_f2e303b4 PS1, Line 256: fieldType we should probably rename this to "listType" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/39593ce5_29791850 PS1, Line 267: null we should change this to use the "open" type. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/d5a0b50b_dc55978b PS1, Line 277: if (tagId == ATypeTag.SERIALIZED_RECORD_TYPE_TAG) { what happens when the list contains lists as items? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie413d286738f571df81e2f450a3fb0b132dc5521 Gerrit-Change-Number: 17488 Gerrit-PatchSet: 1 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 09:43:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
