>From Peeyush Gupta <[email protected]>:

Attention is currently required from: Ali Alsuliman, Till Westmann.
Peeyush Gupta has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 )

Change subject: [ASTERIXDB-3166][FUN] Error with get_object_fields with open 
list type
......................................................................


Patch Set 2:

(2 comments)

File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/a4b2da5a_8f71748d
PS2, Line 193: getLength() - 1
> Interesting. […]
for open list of records, i was getting index out of bounds error. On debugging 
i found this was the issue.


File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordFieldsUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/61832748_8b02e28e
PS2, Line 280: act.getItemType().getTypeTag()
> The assumption here is that the item type is never going to be ATypeTag.UNION 
> (e.g. [int?]). […]
create type test_type as {
   val: [ string? ]
} gives a syntax error

create type test_type as {
   val: [ string ]?
} works
If i understand your question correctly, ATypeTag.UNION should not be a 
possibility for list item types.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie413d286738f571df81e2f450a3fb0b132dc5521
Gerrit-Change-Number: 17488
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Till Westmann <[email protected]>
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ali Alsuliman <[email protected]>
Gerrit-MessageType: comment

Reply via email to