>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ali Alsuliman, Till Westmann. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 )
Change subject: [ASTERIXDB-3166][FUN] Error with get_object_fields with open list type ...................................................................... Patch Set 2: Code-Review+1 (7 comments) File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/get-object-fields/open-list-type/open-list-type.2.update.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/2c32eeba_e46fcf0c PS1, Line 22: INSERT INTO ds1([{"id": "xyz", "some_list":["a","b"]}]); > we should also add some more fields: […] Done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordFieldsUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/c0c429fc_4be8ac00 PS1, Line 98: null > we should change this to use the "open" type. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/8681d3d7_5663576e PS1, Line 162: addNestedField > we should probably rename this to "addRecordField" Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/50a95856_a0f23c33 PS1, Line 245: fieldType == null > can we safely remove this after we make sure we always pass a field type > (closed or open)? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/7235dcda_9de5dcc7 PS1, Line 256: fieldType > we should probably rename this to "listType" Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/55e6e378_e7cba3dd PS1, Line 267: null > we should change this to use the "open" type. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/8eb69ef5_05cc2205 PS1, Line 277: if (tagId == ATypeTag.SERIALIZED_RECORD_TYPE_TAG) { > what happens when the list contains lists as items? For lists of lists, it was not generating the types for fields inside the nested field. There was an issue with list of objects as well which is also fixed with the updated patch. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie413d286738f571df81e2f450a3fb0b132dc5521 Gerrit-Change-Number: 17488 Gerrit-PatchSet: 2 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Comment-Date: Sun, 16 Apr 2023 01:23:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
