>From Ali Alsuliman <[email protected]>: Attention is currently required from: Peeyush Gupta, Till Westmann. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 )
Change subject: [ASTERIXDB-3166][FUN] Error with get_object_fields with open list type ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/1ea03ff9_8d80ec45 PS2, Line 193: getLength() - 1 Interesting. What did you encounter? File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordFieldsUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488/comment/1be972b8_0cfd5eea PS2, Line 280: act.getItemType().getTypeTag() The assumption here is that the item type is never going to be ATypeTag.UNION (e.g. [int?]). Most of the places I have encountered assume the same thing, but I've always wondered whether ATypeTag.UNION as an item type can happen. Can you file an issue to track this (investigate if item type of collection types can be ATypeTag.UNION)? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17488 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie413d286738f571df81e2f450a3fb0b132dc5521 Gerrit-Change-Number: 17488 Gerrit-PatchSet: 2 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Comment-Date: Sun, 16 Apr 2023 10:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
