>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Janhavi Tripurwar. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 )
Change subject: [NO ISSUE]: Introduction of BUILT_IN_FUNCTION entity ...................................................................... Patch Set 6: (2 comments) File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ExpressionUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/0dd49407_f9311b18 PS6, Line 261: if (FunctionUtil.isBuiltinFunctionSignature(signature)) { Builtin functions will come here. I think we will miss ensuring them for things like: CREATE VIEW -> where function X is used. CREATE FUNCTION -> where function X is used. CREATE COLLECTION AS <query> -> where function X is used. You can try each one of these and test. You should also add test cases for these on the other patch. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/EntityDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/df45956d_ce482fe9 PS6, Line 80: isBuiltInFunction Instead of passing the boolean value from the outside, can we compute it inside here? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icf7d0ccef632cf4d95f215b9c0f24ae6fe9d5878 Gerrit-Change-Number: 19490 Gerrit-PatchSet: 6 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Comment-Date: Fri, 14 Mar 2025 02:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
