>From Janhavi Tripurwar <[email protected]>: Attention is currently required from: Ali Alsuliman. Janhavi Tripurwar has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 )
Change subject: [NO ISSUE]: Introduction of BUILT_IN_FUNCTION entity ...................................................................... Patch Set 7: Code-Review+1 (2 comments) File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ExpressionUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/f0d55810_87136fb3 PS6, Line 261: if (FunctionUtil.isBuiltinFunctionSignature(signature)) { > Builtin functions will come here. I think we will miss ensuring them for > things like: […] Yes, these dependencies wee not checked. I have added it now. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/EntityDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/461b02dc_145b5198 PS6, Line 80: isBuiltInFunction > Instead of passing the boolean value from the outside, can we compute it > inside here? Since FunctionUtil is not accessible here, I initially passed it as an argument. However, I've now created a new method in EntityDetails that encapsulates the functionality of isBuiltinFunctionDataverse, eliminating the need to pass isBuiltInFunction. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icf7d0ccef632cf4d95f215b9c0f24ae6fe9d5878 Gerrit-Change-Number: 19490 Gerrit-PatchSet: 7 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Sun, 16 Mar 2025 18:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
