>From Janhavi Tripurwar <[email protected]>: Attention is currently required from: Ali Alsuliman. Janhavi Tripurwar has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 )
Change subject: [NO ISSUE]: Introduction of BUILT_IN_FUNCTION entity ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ExpressionUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/d8aa9a39_b516d5ae PS7, Line 262: addFunctionAccessedEntity(metadataProvider, signature); > Shouldn't we do this only if it's not dataset()? […] Made the changes as discussed and answered the question in the other patch. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/EntityDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/73243e2f_6ee480c0 PS7, Line 124: isBuiltInFunction > I think we should use FunctionUtil.isBuiltinFunctionSignature(signature). […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icf7d0ccef632cf4d95f215b9c0f24ae6fe9d5878 Gerrit-Change-Number: 19490 Gerrit-PatchSet: 8 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Mon, 17 Mar 2025 10:55:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
