>From Ali Alsuliman <[email protected]>: Attention is currently required from: Janhavi Tripurwar. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 )
Change subject: [NO ISSUE]: Introduction of BUILT_IN_FUNCTION entity ...................................................................... Patch Set 7: (2 comments) File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ExpressionUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/03eaa646_fde18f33 PS7, Line 262: addFunctionAccessedEntity(metadataProvider, signature); Shouldn't we do this only if it's not dataset()? i.e. if (FunctionUtil.isBuiltinDatasetFunction(signature)) { } else { addFunctionAccessedEntity(metadataProvider, signature); }. What happens now with your current change? Say you do: SELECT VALUE v FROM Metadata.`Dataverse` v; File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/EntityDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490/comment/e8c390a1_895bba97 PS7, Line 124: isBuiltInFunction I think we should use FunctionUtil.isBuiltinFunctionSignature(signature). If all the args of newFunction() are coming from the FunctionSignature object, then we can change the newFunction() to take only FunctionSignature, and then internally we do everything. (then, you don't need to make isBuiltinFunctionDataverse() public). -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19490 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icf7d0ccef632cf4d95f215b9c0f24ae6fe9d5878 Gerrit-Change-Number: 19490 Gerrit-PatchSet: 7 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Comment-Date: Mon, 17 Mar 2025 00:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
