>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Michael Blow, Murtadha Hubail.

Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email )

Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK
......................................................................


Patch Set 10:

(4 comments)

File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/b61de513_9ebada9c?usp=email
 :
PS5, Line 63:         AWS_ASSUME_ROLE_STALE_TIME(
> It is different than TTL in the sense stale means we need to update, but the 
> credentials are still v […]
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/635c1337_aee47e67?usp=email
 :
PS5, Line 64:                 POSITIVE_INTEGER,
> The credentials will always refresh regardless, just a matter of when to try 
> to refresh them. […]
Done


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/5d6edac2_8d146b1a?usp=email
 :
PS7, Line 66:                 "Time in seconds before the AWS assumed role 
credentials are considered stale and must be updated"),
> In a sense, yes, but entering that point will automatically triggering the 
> refreshing. […]
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/a4c422ff_a6bc609e?usp=email
 :
PS5, Line 335:         }
> Edit […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 10
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Comment-Date: Fri, 24 Oct 2025 14:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Blow <[email protected]>
Comment-In-Reply-To: Hussain Towaileb <[email protected]>

Reply via email to