>From Hussain Towaileb <[email protected]>: Attention is currently required from: Michael Blow, Murtadha Hubail.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email ) Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/fb1c4c00_d4d4048a?usp=email : PS5, Line 70: "Time in seconds before the AWS assumed role credentials are considered close to stale and should be" > As discussed on slack, please include the qualifiers "relative to token > expiration" and "relative to […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/518f48a1_a32e8c5a?usp=email : PS5, Line 74: false, > While we could improve this in the future to use shared client management > across partitions on a nod […] For now, it is per query, per node, per partition. I was planning to do some sharing across nodes or partitions at least, but I think it will not be as straight forward as I expect, so deferring that to another time. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e Gerrit-Change-Number: 20493 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 24 Oct 2025 13:08:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Blow <[email protected]> Comment-In-Reply-To: Hussain Towaileb <[email protected]>
