>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Michael Blow, Murtadha Hubail.

Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email )

Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK
......................................................................


Patch Set 7:

(1 comment)

File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/37ce2a04_ec5ed94c?usp=email
 :
PS5, Line 70:                 "Time in seconds before the AWS assumed role 
credentials are considered close to stale and should be"
> But I still don't get how 300s is "close to something" that 60s is that 
> (literal, not close) "someth […]
More context after more reading:
Stale:
It seems when you hit the stale, let's say 5 minutes mark, the client will use 
synchronous calls to refresh the credentials, effectively blocking the 
execution. If refreshing fails, the SDK will decide whether to fail or continue 
execution with the stale credentials and try to refresh again.


Prefetch:
With prefetch (you can use sync or async) you try to refresh credentials before 
hitting the stale window, which will always be sync. So it seems it is ideal to 
have prefetch with async to avoid blocking the execution. If async is not 
enabled, I don't see the difference between stale with a larger value vs stale 
+ prefetch. But with async enabled, prefetch makes sense.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Comment-Date: Fri, 24 Oct 2025 03:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Blow <[email protected]>
Comment-In-Reply-To: Hussain Towaileb <[email protected]>

Reply via email to