>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb, Murtadha Hubail.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email ) Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK ...................................................................... Patch Set 8: (2 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/eafde490_a1bb20c0?usp=email : PS5, Line 70: "Time in seconds before the AWS assumed role credentials are considered close to stale and should be" > More context after more reading: […] As discussed on slack, please include the qualifiers "relative to token expiration" and "relative to stale time" in the descriptions above, and also please update the qualifier to be "should" here and not "must" for the prefetch property as is the case. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/eb0f0b4a_292396bc?usp=email : PS5, Line 74: false, > I wanted to default this to true, but it defaults to false in the SDK, so I > kept it like this for no […] While we could improve this in the future to use shared client management across partitions on a node to reduce the threads, I still think that async should be the default. Do we stand up and teardown this client on every query, or do we keep it alive across queries? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e Gerrit-Change-Number: 20493 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 24 Oct 2025 12:10:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]> Comment-In-Reply-To: Hussain Towaileb <[email protected]>
