>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ritik Raj.
Wail Alkowaileet has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email ) Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column ...................................................................... Patch Set 4: (3 comments) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/Int32ValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/6f55b9f1_12c41ba7?usp=email : PS4, Line 28: Int32ValueReader IntValueReader maybe? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/LongValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/04504ced_78668aaf?usp=email : PS4, Line 28: LongValueReader I'd rather have a dedicated reader for Date/Time (e.g., TimeValueReader) ...etc. So you can (maybe?) pick a better encoder/decoder. File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/LongColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/c1eab991_ef89e11c?usp=email : PS4, Line 48: ParquetDeltaBinaryPackingValuesWriterForLong I believe there's a dedicated encoder for int values. I didn't include it because everything was 64-bit integers (who will use tinyint or smallint 😊). Here it is: https://github.com/apache/parquet-java/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/delta/DeltaBinaryPackingValuesWriterForInteger.java It requires you to do the same modifications applied in ParquetDeltaBinaryPackingValuesWriterForLong to reduce the memory overhead, but that should be straightforward. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 4 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 14:11:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
