>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ritik Raj.
Wail Alkowaileet has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email ) Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column ...................................................................... Patch Set 6: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/d33034b8_68fd97d6?usp=email : PS5, Line 23: DURATION and : INTERVAL > Since duration and intervals are incomparable, hence it won't make sense ig > to have min/max and comp […] I meant in the commit message 😊 File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/temporal/IntervalValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/076002dd_2271ea42?usp=email : PS5, Line 75: intervalTimeType > An Interval can be between date, time, and datetime. […] Agreed on separating them into three types. I suggest sending an email to the dev to open the discussion. File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/DurationColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/0f4e20fe_98234843?usp=email : PS5, Line 55: * NOTE: Since the columnar page-zero filter stores only two 8-byte longs, we cannot safely create an : * order-preserving single-long min/max representation for DURATION. This writer therefore stores the values, but : * uses a conservative filter that avoids pruning based on DURATION filters. > Yeah, that compare did confuse me, but Duration can't be compare […] I'm super oblivious to those temporal types (didn't work on them at all). However, the #compareTo function must provide some sort of "order" -- so ORDER BY can work. Also, the implementation of ordering should work as the ordering of building an index as well as ORDER BY. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Sun, 18 Jan 2026 06:57:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]>
