>From Ritik Raj <[email protected]>: Attention is currently required from: Wail Alkowaileet.
Ritik Raj has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email ) Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column ...................................................................... Patch Set 5: (3 comments) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/Int32ValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/aeade36b_d39e17d6?usp=email : PS4, Line 28: Int32ValueReader > IntValueReader maybe? Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/LongValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/fc9c8eec_6229dc53?usp=email : PS4, Line 28: LongValueReader > I'd rather have a dedicated reader for Date/Time (e.g., TimeValueReader) > ...etc. […] Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/LongColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/3d28356d_d4867198?usp=email : PS4, Line 48: ParquetDeltaBinaryPackingValuesWriterForLong > I believe there's a dedicated encoder for int values. […] True, we already have a ParquetDeltaBinaryPackingValuesWriterForInteger, used that to create a new IntColumnValuesWriter -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 07:20:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]>
