>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ritik Raj.
Wail Alkowaileet has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email ) Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: One thought... I would pick a few tests to see if we should use any type of encoder or simply just store the temporal values as plain. The tests should measure both storage size and performance. I also would recommend including some "unit tests" under [1]. To test the correctness of storing and displaying those new values. This may require you to use the ADM parser instead of the JSON parser that is used in those unit tests. It could be in a subsequent patch. [1] https://github.com/apache/asterixdb/tree/master/asterixdb/asterix-column/src/test/resources File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/LongColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/5aeacae8_2c411d5d?usp=email : PS4, Line 48: ParquetDeltaBinaryPackingValuesWriterForLong > True, we already have a ParquetDeltaBinaryPackingValuesWriterForInteger, used > that to create a new I […] Ah! I thought I deleted it 😊 You might need to test it rigorously. I haven't tested it thoroughly AFAIR. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 08:15:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]>
