>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ritik Raj.
Wail Alkowaileet has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email ) Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column ...................................................................... Patch Set 7: Code-Review+2 (5 comments) Patchset: PS7: Those comments can be addressed once we reach a point about how to store the interval values (in a follow-up patch). File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/key/temporal/DayTimeDurationKeyValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/4de5b1bd_9b022f85?usp=email : PS7, Line 26: DayTimeDurationKeyValueReader Can this be a key? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/key/temporal/YearMonthDurationKeyValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/3285bfec_6a9f015f?usp=email : PS7, Line 26: YearMonthDurationKeyValueReader Can this be a key? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/temporal/IntervalValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/d0d6dd88_585328f4?usp=email : PS7, Line 37: TYPE_BIT_WIDTH Minor: Do we need the whole 8 bits here? I know we need 3 bits only, right? We don't have to store the whole typetag (e.g., it cannot be object) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/0af359c9_98ec7f36?usp=email : PS7, Line 81: bytes[s] = (byte) intervalTimeType; : if (intervalTimeType == ATypeTag.DATETIME.serialize()) { : LongPointable.setLong(bytes, s + 1, start); : LongPointable.setLong(bytes, s + 1 + Long.BYTES, end); : } else { : IntegerPointable.setInteger(bytes, s + 1, (int) start); : IntegerPointable.setInteger(bytes, s + 1 + Integer.BYTES, (int) end); : } This logic should be centralized in the IntervalPointable (as in LongPointable). -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 06:13:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
