>From Wail Alkowaileet <[email protected]>:

Attention is currently required from: Ritik Raj.

Wail Alkowaileet has posted comments on this change by Ritik Raj. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email )

Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column
......................................................................


Patch Set 6:

(1 comment)

File 
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/DurationColumnValuesWriter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/d9761069_e0d0c5cb?usp=email
 :
PS5, Line 55: * NOTE: Since the columnar page-zero filter stores only two 
8-byte longs, we cannot safely create an
            :  * order-preserving single-long min/max representation for 
DURATION. This writer therefore stores the values, but
            :  * uses a conservative filter that avoids pruning based on 
DURATION filters.
> I forgot to mention about this […]
As I mentioned to you on Slack, I think we should revisit all these types and 
see what other systems do. If Gemini isn't lying to me [1], PostgreSQL allows 
such comparisons. Logically, a duration is a period of time (to my simple 
understanding). E.g., 1 hour > 1 minute, no?

[1] https://share.google/aimode/ArZdl3IEAF0LbZrGG



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248
Gerrit-Change-Number: 20773
Gerrit-PatchSet: 6
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jan 2026 09:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wail Alkowaileet <[email protected]>
Comment-In-Reply-To: Ritik Raj <[email protected]>

Reply via email to