>From Ritik Raj <[email protected]>: Attention is currently required from: Wail Alkowaileet.
Ritik Raj has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email ) Change subject: [ASTERIXDB-3684][STO] Support temporal types in Column ...................................................................... Patch Set 6: (1 comment) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/DurationColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773/comment/925b2933_75b44680?usp=email : PS5, Line 55: * NOTE: Since the columnar page-zero filter stores only two 8-byte longs, we cannot safely create an : * order-preserving single-long min/max representation for DURATION. This writer therefore stores the values, but : * uses a conservative filter that avoids pruning based on DURATION filters. > checked with team as well, will update to have a filter on the months. […] I forgot to mention about this ``` FROM [ { "id": "1", "name": "Z" , "d": duration("P2MT1M")}, { "id": "2", "name": "kirk", "d": duration("P1MT1233412414124142M") } ] p where p.d >= duration("P1MT1233412414124142M") SELECT p; ``` Ig the comparison is only for order by, and it can't be applied to filters according to current comparison semantics. the above query gives empty result because ``` duration("P1MT1233412414124142M") >= duration("P1MT1233412414124142M"); --- returns null ``` so maybe min/max filter can't be maintained, but compareTo should be provided, which have an implementation in reader, I will modify it to compare month first, and then touch millis. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20773?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdf63561cd5e7c73801380cf0a7c1b5be9c9248 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 08:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]>
