From Michael Blow <[email protected]>: Attention is currently required from: Ian Maxon, Peeyush Gupta.
Michael Blow has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email ) Change subject: [ASTERIXDB-3636][API] Migrate UDF API to domain sockets ...................................................................... Patch Set 14: (10 comments) File asterixdb/asterix-app/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/5814ec69_dcacd261?usp=email : PS14, Line 873: <exclusion> : <groupId>io.netty</groupId> : <artifactId>netty-resolver-dns</artifactId> : </exclusion> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>netty-resolver-dns-classes-macos</artifactId> : </exclusion> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>netty-resolver-dns-native-macos</artifactId> : </exclusion> i think these three shouldn't be needed since they are already under dependency management, but it certainly isn't hurting anything. File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/RetrieveLibrariesTask.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/77789750_2fdc54c7?usp=email : PS14, Line 52: transient I don't think this can have any impact, since this is a final field. File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/797924d7_2e49d12b?usp=email : PS14, Line 278: Pair<Map<String, String>, Map<String, String>> auth = : BasicAuthServlet.generateSysAuthHeader(apiServer.ctx()); : apiServer.addServlet((new BasicAuthServlet(apiServer.ctx(), : new NCUdfApiServlet(apiServer.ctx(), new String[] { UDF }, getApplicationContext(), : apiServer.getScheme(), externalProperties.getNcApiPort()), : auth.getFirst(), auth.getSecond()))); : apiServer.addServlet(new BasicAuthServlet(apiServer.ctx(), : new NCUdfRecoveryServlet(apiServer.ctx(), new String[] { UDF_RECOVERY }, getApplicationContext()), : auth.getFirst(), auth.getSecond())); : are we going to continue to support the old UDFs? File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/b1a2f814_d27c2afb?usp=email : PS14, Line 111: temporary directory/asterixdb_udf/$NODE_ID_udf.sock can we make this `<tmpdir>/asterixdb_udf/${NODE_ID}_udf.sock`? this is a bit hard to parse for me at a glance. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/f6279c88_efecb0b5?usp=email : PS14, Line 254: Defaults to default.dir/udf.sock i don't think we usually include the default desc here, since it already is picked up as a separate field File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/6b3df49c_ba7faa8a?usp=email : PS14, Line 129: private String getPort(SocketAddress s) { : if (s instanceof InetSocketAddress) { : return NetworkUtil.toHostPort((InetSocketAddress) channel.localAddress()); : } : return "0"; : } : what is this supposed to return? I don't quite get how "0" is a host:port File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/4ddc06ca_befd2cdb?usp=email : PS14, Line 139: return addr.toString(); what can `addr` aside from a `InetSocketAddress` or a `UnixDomainSocketAddress`? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/a5c5a256_8102a908?usp=email : PS14, Line 160: int[] ports = addresses.stream().filter(s -> s instanceof InetSocketAddress) : .mapToInt(s -> ((InetSocketAddress) s).getPort()).distinct().toArray(); ```suggestion int[] ports = addresses.stream() .filter(InetSocketAddress.class::isInstance) .map(InetSocketAddress.class::cast) .mapToInt(InetSocketAddress::getPort) .distinct() .toArray(); ``` idk if this is better or not, just thought about it. Similar pattern would work on L164-165 as well https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/cfefea37_94ead63f?usp=email : PS14, Line 418: deleteDomainSockFiles(); what happens if we don't clean these up? should we do it in a finally? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/f7adba2e_b030da74?usp=email : PS14, Line 479: so we need to clean them up on shutdown what happens if we don't clean these up, e.g. on a crash -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5f8ac2170fd6b2beef14d99c38b9141af0f12ba3 Gerrit-Change-Number: 20492 Gerrit-PatchSet: 14 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Tue, 17 Feb 2026 22:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
