From Michael Blow <[email protected]>: Attention is currently required from: Ian Maxon, Peeyush Gupta.
Michael Blow has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email ) Change subject: [ASTERIXDB-3636][API] Migrate UDF API to domain sockets ...................................................................... Patch Set 14: (4 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/ce6d9086_27f1b341?usp=email : PS14, Line 278: Pair<Map<String, String>, Map<String, String>> auth = : BasicAuthServlet.generateSysAuthHeader(apiServer.ctx()); : apiServer.addServlet((new BasicAuthServlet(apiServer.ctx(), : new NCUdfApiServlet(apiServer.ctx(), new String[] { UDF }, getApplicationContext(), : apiServer.getScheme(), externalProperties.getNcApiPort()), : auth.getFirst(), auth.getSecond()))); : apiServer.addServlet(new BasicAuthServlet(apiServer.ctx(), : new NCUdfRecoveryServlet(apiServer.ctx(), new String[] { UDF_RECOVERY }, getApplicationContext()), : auth.getFirst(), auth.getSecond())); : > for the time being in asterix yeah, that was my thought anyway. […] Acknowledged File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/ff24ec5d_0806f928?usp=email : PS14, Line 129: private String getPort(SocketAddress s) { : if (s instanceof InetSocketAddress) { : return NetworkUtil.toHostPort((InetSocketAddress) channel.localAddress()); : } : return "0"; : } : > it isn't, i could return null. domain sockets don't have ports like TCP > sockets do. so for InetSocketAddress this returns host:port, and for all other socket addresses it returns "0", right? File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/61eb4ff9_eaadc44d?usp=email : PS14, Line 139: return addr.toString(); > some of the netty native transports expose a different implementation (e.g. > DomainSocketAddress). […] Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/75a2c951_0fe2e251?usp=email : PS14, Line 418: deleteDomainSockFiles(); > if you don't clean it up and attempt to rebind the socket on the same file, > it will fail like when y […] so do we clean it up when we try to bind at startup? we can be `kill -9`'d -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5f8ac2170fd6b2beef14d99c38b9141af0f12ba3 Gerrit-Change-Number: 20492 Gerrit-PatchSet: 14 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 16:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Michael Blow <[email protected]>
