>From Michael Blow <[email protected]>: Attention is currently required from: Ian Maxon, Peeyush Gupta.
Michael Blow has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email ) Change subject: [ASTERIXDB-3636][API] Migrate UDF API to domain sockets ...................................................................... Patch Set 15: Code-Review+2 (1 comment) File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/703b8407_e73306d5?usp=email : PS14, Line 129: private String getPort(SocketAddress s) { : if (s instanceof InetSocketAddress) { : return NetworkUtil.toHostPort((InetSocketAddress) channel.localAddress()); : } : return "0"; : } : > yes, since at least for now i think any other instance shouldn't have a > concept of port, and null sc […] I guess what confused me is that the API says "getPort", but is returning a host:port string. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5f8ac2170fd6b2beef14d99c38b9141af0f12ba3 Gerrit-Change-Number: 20492 Gerrit-PatchSet: 15 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 17:32:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Michael Blow <[email protected]>
