From Ian Maxon <[email protected]>: Attention is currently required from: Michael Blow, Peeyush Gupta.
Ian Maxon has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email ) Change subject: [ASTERIXDB-3636][API] Migrate UDF API to domain sockets ...................................................................... Patch Set 15: (2 comments) File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/4916036b_12876e32?usp=email : PS14, Line 129: private String getPort(SocketAddress s) { : if (s instanceof InetSocketAddress) { : return NetworkUtil.toHostPort((InetSocketAddress) channel.localAddress()); : } : return "0"; : } : > so for InetSocketAddress this returns host:port, and for all other socket > addresses it returns "0", […] yes, since at least for now i think any other instance shouldn't have a concept of port, and null scares me File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492/comment/b995c52a_a9656d79?usp=email : PS14, Line 418: deleteDomainSockFiles(); > so do we clean it up when we try to bind at startup? we can be `kill -9`'d i was trying to avoid that because i have a lot of trepidation about deleting any path or file given as a config parameter. however after researching a bit i don't think there's any other robust way. if the process crashed it would fail to start again for sure with a bind failure. i believe it should be safe if it's done like this: - try connecting to the socket. if it is live, don't delete it. - if the socket can't be connected to, and is a 0 length special file, then delete it before binding. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20492?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5f8ac2170fd6b2beef14d99c38b9141af0f12ba3 Gerrit-Change-Number: 20492 Gerrit-PatchSet: 15 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 17:29:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Michael Blow <[email protected]>
