CrazyHZM commented on code in PR #10164:
URL: https://github.com/apache/dubbo/pull/10164#discussion_r902279974
##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java:
##########
@@ -93,6 +93,10 @@ public Result doInvoke(Invocation invocation, final
List<Invoker<T>> invokers, L
if (e.isBiz()) { // biz exception.
throw e;
}
+ if (e.getCause() != null &&
InterruptedException.class.getName().equals(e.getCause().toString())) {
+ // don`t catch interrupt exception
+ throw new RuntimeException(e);
+ }
Review Comment:
Interrupting a thread is not a common scenario, and I don't approve of
modifying non-generic logic.
Based on your scenario, I think you may need a custom Cluster implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
