CrazyHZM commented on code in PR #10164:
URL: https://github.com/apache/dubbo/pull/10164#discussion_r902297511
##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java:
##########
@@ -93,6 +93,10 @@ public Result doInvoke(Invocation invocation, final
List<Invoker<T>> invokers, L
if (e.isBiz()) { // biz exception.
throw e;
}
+ if (e.getCause() != null &&
InterruptedException.class.getName().equals(e.getCause().toString())) {
+ // don`t catch interrupt exception
+ throw new RuntimeException(e);
+ }
Review Comment:
For example, if it is not normal behavior to interrupt the thread, dubbo
still needs to initiate a retry. If it is modified according to the above
logic, the retry capability will be invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
