happytimor commented on code in PR #10164:
URL: https://github.com/apache/dubbo/pull/10164#discussion_r902292016


##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java:
##########
@@ -93,6 +93,10 @@ public Result doInvoke(Invocation invocation, final 
List<Invoker<T>> invokers, L
                 if (e.isBiz()) { // biz exception.
                     throw e;
                 }
+                if (e.getCause() != null && 
InterruptedException.class.getName().equals(e.getCause().toString())) {
+                    // don`t catch interrupt exception
+                    throw new RuntimeException(e);
+                }

Review Comment:
   my code is like this
   
   ``` java
   Future<?> future =RUNNER_EXECUTOR.submit(() -> {
       pipelineService.startTask(taskId);
   });
   ```
   ``` java
   //because some logic error, i need find the future and  cancel task
   future.cancel();
   ```
   
   i think it is a normal scenario......
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to