QuentinYo commented on code in PR #12118:
URL: https://github.com/apache/dubbo/pull/12118#discussion_r1172386087
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -209,6 +219,51 @@ public void unexport() {
repository.unregisterProvider(providerModel);
}
+ private void waitForIdle() {
+ int timeout =
ConfigurationUtils.getServerShutdownTimeout(getScopeModel());
+
+ long idleTime = System.currentTimeMillis() -
providerModel.getLastInvokeTime();
Review Comment:
> 想一个极端场景：业务服务就是每10s调用一次，会不会在某次请求达到一个正在停机的provider上却处理不了呢。
不确定我举的这个例子是否正确
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
