[GitHub] [dubbo] QuentinYo commented on a diff in pull request #12118: Support Shutdown Gracefully

[via GitHub]

QuentinYo commented on code in PR #12118:
URL: https://github.com/apache/dubbo/pull/12118#discussion_r1177645799


##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -194,6 +196,14 @@ public void unexport() {
             return;
         }
         if (!exporters.isEmpty()) {
+            for (Exporter<?> exporter : exporters) {
+                try {
+                    exporter.unregister();
+                } catch (Throwable t) {
+                    logger.warn(CONFIG_UNEXPORT_ERROR, "", "", "Unexpected 
error occurred when unexport " + exporter, t);
+                }
+            }
+            waitForIdle();

Review Comment:
   应用级服务下线需要配合下面的配置。（默认配置最大30s后才同步到注册中心）
   
org.apache.dubbo.config.deploy.DefaultApplicationDeployer#registerServiceInstance
   
![image](https://user-images.githubusercontent.com/7312478/234541407-cceeea9a-0958-4c95-b85f-8cf14ab487c5.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org