QuentinYo commented on code in PR #12118:
URL: https://github.com/apache/dubbo/pull/12118#discussion_r1177306661
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -194,6 +196,14 @@ public void unexport() {
return;
}
if (!exporters.isEmpty()) {
+ for (Exporter<?> exporter : exporters) {
+ try {
+ exporter.unregister();
+ } catch (Throwable t) {
+ logger.warn(CONFIG_UNEXPORT_ERROR, "", "", "Unexpected
error occurred when unexport " + exporter, t);
+ }
+ }
+ waitForIdle();
Review Comment:
如果一个dubbo项目有多个接口（ServiceBean），每个ServiceBean进行unexport的时候都需要等待，会导致停机时间变成10*n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
