[GitHub] [dubbo] QuentinYo commented on a diff in pull request #12118: Support Shutdown Gracefully

[via GitHub]

QuentinYo commented on code in PR #12118:
URL: https://github.com/apache/dubbo/pull/12118#discussion_r1177522069


##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -194,6 +196,14 @@ public void unexport() {
             return;
         }
         if (!exporters.isEmpty()) {
+            for (Exporter<?> exporter : exporters) {
+                try {
+                    exporter.unregister();
+                } catch (Throwable t) {
+                    logger.warn(CONFIG_UNEXPORT_ERROR, "", "", "Unexpected 
error occurred when unexport " + exporter, t);
+                }
+            }
+            waitForIdle();

Review Comment:
   offline 那部分逻辑貌似无法下掉应用级的注册信息。
   org.apache.dubbo.registry.client.ServiceDiscoveryRegistry#unregister
   
![image](https://user-images.githubusercontent.com/7312478/234515264-96ce4d19-5878-4c15-b6a1-f7f2ff4cfff3.png)
   
   
org.apache.dubbo.registry.client.AbstractServiceDiscovery#unregister(org.apache.dubbo.common.URL)
   
![image](https://user-images.githubusercontent.com/7312478/234515549-eeaa30ed-eb0f-4fae-bf3d-dd4c5f83cbc2.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org