moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r453770010
##########
File path: cppcache/src/TcrMessage.cpp
##########
@@ -1015,6 +1015,36 @@ void TcrMessage::processChunk(const
std::vector<uint8_t>& chunk, int32_t len,
break;
}
// fall-through for other cases
+ if (m_chunkedResult != nullptr) {
Review comment:
The previous code did a fallthrough if it didn't make it to the `break;`
statement on line 999 or 1015 (which is buried in an `if` and `if else`). This
is the same code as on line 1054. I thought about extracting a function but
got lazy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
