moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r454468644
##########
File path: cppcache/include/geode/DataInput.hpp
##########
@@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput {
// empty string
break;
// TODO: What's the right response here?
- default:
+ case internal::DSCode::FixedIDDefault:
Review comment:
Per some other avenue feedback from @pdxcodemonkey and @mreddington ,
I'll take some time to change this to a 4 way `if-else if` since it seems this
is not much better. For the latter list in `ExceptionTypes.cpp`, I'll try a
map approach (similar to `start_element_map_` and `end_element_map_` in
CacheXmlParser
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
