pdxcodemonkey commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r453895218
##########
File path: cppcache/include/geode/DataInput.hpp
##########
@@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput {
// empty string
break;
// TODO: What's the right response here?
- default:
+ case internal::DSCode::FixedIDDefault:
Review comment:
Sorry, I don't think the chance of getting a warning for free is worth
the cost of some egregious cluttering of the code. We're only using 4 of the
61 possible values for a DSCode, so it was kind of an abuse of a switch
statement to begin with. This should probably just be a 4-way if-else block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
