moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r453775780
##########
File path: cppcache/include/geode/DataInput.hpp
##########
@@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput {
// empty string
break;
// TODO: What's the right response here?
- default:
+ case internal::DSCode::FixedIDDefault:
Review comment:
I actually like it since it forces you to acknowledge all possible
switches for an enum (which is enumerable). That way you don't accidentally go
to the default when adding a new enum. If the general consensus is we prefer
not to change `-Wno-switch-enum` then we can revert that commit. I could make
it worse by adding `break;` statements in between all the cases :-p
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
