pdxcodemonkey commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r591789633
##########
File path: cppcache/integration-test/CMakeLists.txt
##########
@@ -30,6 +30,7 @@ target_link_libraries(test-cppcache-utils
PUBLIC
apache-geode
framework
+ SPDLog::SPDLog
Review comment:
This may or may not be vestigial - I'll have to check. spdlog is a
header-only library, at least as we're using it, so this dependency just means
we need to include one of its headers. But again, I'm not sure that's the case
any more, so I will try to remove this ref.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
