pivotal-jbarrett commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r591920914
##########
File path: cppcache/src/Log.cpp
##########
@@ -45,9 +45,21 @@ const int LOG_SCRATCH_BUFFER_SIZE = 16 * __1K__;
static std::recursive_mutex g_logMutex;
static std::shared_ptr<spdlog::logger> currentLogger;
static LogLevel currentLevel = LogLevel::None;
+static std::string logFilePath;
+static int32_t adjustedFileSizeLimit;
+static int32_t maxFiles;
const std::shared_ptr<spdlog::logger>& getCurrentLogger() {
- return currentLogger;
+ if (logFilePath.empty()) {
Review comment:
In the Java bits we landed on `-`, consistent with lots of utilities, as
the indicator to use `stdout` logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
