[GitHub] [geode-benchmarks] pivotal-jbarrett commented on a change in pull request #150: Adds Redis benchmarks.

[GitBox]

pivotal-jbarrett commented on a change in pull request #150:
URL: https://github.com/apache/geode-benchmarks/pull/150#discussion_r631960159



##########
File path: 
geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/ExecuteFilteredFunction.java
##########
@@ -55,13 +60,18 @@ public void setUp(BenchmarkConfiguration cfg) throws 
Exception {
   public boolean test(Map<Object, Object> ctx) {
     final Set<Long> filterSet = Collections.singleton(keyRange.random());
     @SuppressWarnings("unchecked")
-    final ResultCollector<?, ?> resultCollector = FunctionService
+    final Object result = FunctionService
         .onRegion(region)
         .withFilter(filterSet)
-        .execute(function);
-    resultCollector.getResult();
-    return true;
+        .execute(function)
+        .getResult();
 
+    if (isValidationEnabled) {

Review comment:
       This question does highlight that the null check and the instanceof 
check are redundant though. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org